Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(PPDSC-2474): add overrides storybook themes support #503

Merged

Conversation

evgenitsn
Copy link
Contributor

PPDSC-2474

What

Added the new themes which are used only for Storybook and just for the Scenarios named "Styling overrides".
The themes storybookNewsKitLight and storybookNewsKitDark are based on the newsKitLight and newsKitDark but with overridden colours.

Usage: If you have a Styling overrides story in your work you have to provide a decorator with <ThemeProvider> and pass the context.name to the createCustomThemeWithBaseThemeSwitch as last argument. And also the theme is applied only if there is a scenarios section called Styling overrides.

You can have a look at the banner.stories.tsx.

I have done:

  • Written unit tests against changes
  • Written functional tests against the component and/or NewsKit site
  • Updated relevant documentation

I have tested manually:

  • The feature's functionality is working as expected on Chrome, Firefox, Safari and Edge
  • The screen reader reads and flows through the elements as expected.
  • There are no new errors in the browser console coming from this PR.
  • When visual test is not added, it renders correctly on different browsers and mobile viewports (Safari, Firefox, small mobile viewport, tablet)
  • The Playground feature is working as expected

Before:

image

After:

image

Who should review this PR:

How to test:

@evgenitsn evgenitsn added docs Improvements or additions to documentation ready for design review Please assist in getting this reviewed labels Dec 1, 2022
@evgenitsn evgenitsn requested a review from a team as a code owner December 1, 2022 13:29
Copy link
Contributor

@mutebg mutebg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good

@evgenitsn evgenitsn merged commit 682f400 into main Dec 2, 2022
@evgenitsn evgenitsn deleted the docs/PPDSC-2474-add-overrides-storybook-themes-support branch December 2, 2022 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to documentation ready for design review Please assist in getting this reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants